executer: fix data race (#30186)

pingcap · Nov 29, 2021 · 3487bb7 · 3487bb7
1 parent 6756bd2
commit 3487bb7
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/executor/builder.go b/executor/builder.go
@@ -4698,20 +4698,20 @@ func (b *executorBuilder) getCacheTable(tblInfo *model.TableInfo, startTS uint64
 		b.ctx.GetSessionVars().StmtCtx.ReadFromTableCache = true
 		return cacheData
 	}
-	go func() {
-		defer func() {
-			if r := recover(); r != nil {
-				logutil.BgLogger().Error("panic in the recoverable goroutine",
-					zap.Reflect("r", r),
-					zap.Stack("stack trace"))
-			}
-		}()
-		if !b.ctx.GetSessionVars().StmtCtx.InExplainStmt && !b.inDeleteStmt && !b.inUpdateStmt {
+	if !b.ctx.GetSessionVars().StmtCtx.InExplainStmt && !b.inDeleteStmt && !b.inUpdateStmt {
+		go func() {
+			defer func() {
+				if r := recover(); r != nil {
+					logutil.BgLogger().Error("panic in the recoverable goroutine",
+						zap.Reflect("r", r),
+						zap.Stack("stack trace"))
+				}
+			}()
 			err := tbl.(table.CachedTable).UpdateLockForRead(b.ctx.GetStore(), startTS)
 			if err != nil {
 				log.Warn("Update Lock Info Error")
 			}
-		}
-	}()
+		}()
+	}
 	return nil
 }