address comment

Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
pingcap · Sep 6, 2021 · 3b3cc05 · 3b3cc05
1 parent 46d24f4
commit 3b3cc05
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/br/pkg/lightning/restore/check_info.go b/br/pkg/lightning/restore/check_info.go
@@ -19,7 +19,6 @@ import (
 	"context"
 	"fmt"
 	"io"
-	"modernc.org/mathutil"
 	"path/filepath"
 	"reflect"
 	"sort"
@@ -40,13 +39,14 @@ import (
 	"github.com/pingcap/tidb/br/pkg/lightning/log"
 	"github.com/pingcap/tidb/br/pkg/lightning/mydump"
 	"github.com/pingcap/tidb/br/pkg/lightning/verification"
-	"github.com/pingcap/tidb/br/pkg/pdutil"
 	"github.com/pingcap/tidb/br/pkg/storage"
 	"github.com/pingcap/tidb/br/pkg/version"
 	"github.com/pingcap/tidb/table/tables"
 	"github.com/tikv/pd/server/api"
 	pdconfig "github.com/tikv/pd/server/config"
+
 	"go.uber.org/zap"
+	"modernc.org/mathutil"
 )
 
 const (
@@ -315,7 +315,7 @@ func (rc *Controller) checkRegionDistribution(ctx context.Context) error {
 }
 
 // CheckClusterRegion checks cluster if there are too many empty regions or region distribution is unbalanced.
-func (rc *Controller) CheckClusterRegion(ctx context.Context, controller *pdutil.PdController) error {
+func (rc *Controller) CheckClusterRegion(ctx context.Context) error {
 	err := rc.taskMgr.CheckTasksExclusively(ctx, func(tasks []taskMeta) ([]taskMeta, error) {
 		restoreStarted := false
 		for _, task := range tasks {

diff --git a/br/pkg/lightning/restore/restore.go b/br/pkg/lightning/restore/restore.go
@@ -1755,7 +1755,7 @@ func (rc *Controller) preCheckRequirements(ctx context.Context) error {
 				rc.taskMgr.CleanupTask(ctx)
 				return errors.Trace(err)
 			}
-			if err := rc.CheckClusterRegion(ctx, pdController); err != nil {
+			if err := rc.CheckClusterRegion(ctx); err != nil {
 				return errors.Trace(err)
 			}
 		}