add test

pingcap · Dec 2, 2021 · a2e124a · a2e124a
1 parent ae39e53
commit a2e124a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/expression/builtin_string_vec_test.go b/expression/builtin_string_vec_test.go
@@ -330,6 +330,12 @@ var vecBuiltinStringCases = map[string][]vecExprBenchCase{
 			geners:        []dataGenerator{&charInt64Gener{}, &charInt64Gener{}, &charInt64Gener{}, nil},
 			constants:     []*Constant{nil, nil, nil, {Value: types.NewDatum("ascii"), RetType: types.NewFieldType(mysql.TypeString)}},
 		},
+		{
+			retEvalType:   types.ETString,
+			childrenTypes: []types.EvalType{types.ETInt, types.ETInt, types.ETInt, types.ETString},
+			geners:        []dataGenerator{&charInt64Gener{}, nil, &charInt64Gener{}, nil},
+			constants:     []*Constant{nil, nil, nil, {Value: types.NewDatum("ascii"), RetType: types.NewFieldType(mysql.TypeString)}},
+		},
 	},
 	ast.FindInSet: {
 		{retEvalType: types.ETInt, childrenTypes: []types.EvalType{types.ETString, types.ETString}},

diff --git a/expression/integration_test.go b/expression/integration_test.go
@@ -10653,13 +10653,12 @@ func (s *testIntegrationSuite) TestIssue29755(c *C) {
 	tk := testkit.NewTestKit(c, s.store)
 	tk.MustExec("use test")
 
-	tk.MustExec("drop table if exists t")
-	tk.MustExec("create table t(a int);")
-	tk.MustExec("insert into t values (NULL), (0x61);")
 	tk.MustExec("set tidb_enable_vectorized_expression = on;")
-	tk.MustQuery("select char(a) from t;").Check(testkit.Rows("", "a"))
+	tk.MustQuery("select char(123, NULL, 123)").Check(testkit.Rows("{{"))
+	tk.MustQuery("select char(NULL, 123, 123)").Check(testkit.Rows("{{"))
 	tk.MustExec("set tidb_enable_vectorized_expression = off;")
-	tk.MustQuery("select char(a) from t;").Check(testkit.Rows("", "a"))
+	tk.MustQuery("select char(123, NULL, 123)").Check(testkit.Rows("{{"))
+	tk.MustQuery("select char(NULL, 123, 123)").Check(testkit.Rows("{{"))
 }
 
 func (s *testIntegrationSuite) TestIssue30101(c *C) {