Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for expression #26855

Closed
57 tasks done
Tracked by #26022
tisonkun opened this issue Aug 3, 2021 · 6 comments
Closed
57 tasks done
Tracked by #26022

migrate test-infra to testify for expression #26855

tisonkun opened this issue Aug 3, 2021 · 6 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021 •
edited by hawkingrei
Loading

You may try to analyze first and spawn more subtasks instead of one big PR handle the whole package which is hard to review.
@tisonkun tisonkun mentioned this issue Aug 3, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 3, 2021
@penthaapatel penthaapatel mentioned this issue Sep 8, 2021
Closed
4 tasks
@penthaapatel
Copy link
Contributor

Hi @tisonkun, I'd like to migrate tests under expression/aggregation pkg. So I created a new issue #27904 to track the changes easily. Could you add the newly created issue as a subtask of this issue?

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 8, 2021

@penthaapatel added. Thanks a lot for your participant!

tisonkun added a commit to tisonkun/tidb that referenced this issue Oct 25, 2021
@tisonkun
expression: migrate generated tests to testify
bdba1b1 
This refers pingcap#26855 .

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun mentioned this issue Oct 25, 2021
Merged
tisonkun added a commit to tisonkun/tidb that referenced this issue Oct 26, 2021
@tisonkun
expression: migrate builtin tests [a-e]
b19ee43 
This refers to pingcap#26855 .

Signed-off-by: tison <wander4096@gmail.com>
@tisonkun tisonkun mentioned this issue Oct 26, 2021
Merged
@tisonkun
Copy link
Contributor Author

Closed as all subtasks done.

@hawkingrei
Copy link
Member

hawkingrei commented Dec 10, 2021 •
edited
Loading

In fact, Many tasks like analyze_test.go are not migrated

@hawkingrei hawkingrei reopened this Dec 10, 2021
@tisonkun
Copy link
Contributor Author

@hawkingrei sorry that I miss the file :P

@tisonkun
Copy link
Contributor Author

Closed as all subtasks done.

@hawkingrei could you please do a sanity check?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hawkingrei @tisonkun @penthaapatel