Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for planner/core #26857

Closed
30 tasks done
Tracked by #26022
tisonkun opened this issue Aug 3, 2021 · 5 comments · Fixed by #32597
Closed
30 tasks done
Tracked by #26022

migrate test-infra to testify for planner/core #26857

tisonkun opened this issue Aug 3, 2021 · 5 comments · Fixed by #32597
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Aug 3, 2021 •
edited
Loading

You may try to analyze first and spawn more subtasks instead of one big PR handle the whole package which is hard to review.
@tisonkun tisonkun mentioned this issue Aug 3, 2021
Closed
53 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 3, 2021
@karuppiah7890
Copy link
Contributor

karuppiah7890 commented Sep 27, 2021 •
edited
Loading

@tisonkun You can maybe add this list of sub tasks per file ?

  • planner/core/cache_test.go
  • planner/core/cacheable_checker_test.go
  • planner/core/cbo_test.go
  • planner/core/enforce_mpp_test.go
  • planner/core/errors_test.go
  • planner/core/exhaust_physical_plans_test.go
  • planner/core/expression_rewriter_test.go
  • planner/core/expression_test.go
  • planner/core/find_best_task_test.go
  • planner/core/indexmerge_test.go
  • planner/core/integration_partition_test.go
  • planner/core/integration_test.go
  • planner/core/logical_plan_test.go
  • planner/core/logical_plans_test.go
  • planner/core/memtable_predicate_extractor_test.go
  • planner/core/optimizer_test.go
  • planner/core/partition_pruner_test.go
  • planner/core/partition_pruning_test.go
  • planner/core/physical_plan_test.go
  • planner/core/plan_test.go
  • planner/core/plan_to_pb_test.go
  • planner/core/planbuilder_test.go
  • planner/core/point_get_plan_test.go
  • planner/core/prepare_test.go
  • planner/core/preprocess_test.go
  • planner/core/rule_inject_extra_projection_test.go
  • planner/core/rule_join_reorder_dp_test.go
  • planner/core/rule_result_reorder_test.go
  • planner/core/stats_test.go

@tisonkun
Copy link
Contributor Author

tisonkun commented Sep 27, 2021 •
edited
Loading

@karuppiah7890 thanks for your help! The description is updated.

main_test.go needs not to be migrated

You can start as the order I create this issues (see also the issues list page) the latter are more complex in my opinion, especially for these I don't mark as "good first issue".

@tisonkun
Copy link
Contributor Author

@karuppiah7890 also I suggest you take a look at the non testing code during the journey. They are one of the core functions of TiDB as a SQL engine. You can ask any question about the implementation or design at https://internals.tidb.io/c/sqlengine . I think there are many to-do works for an optimized optimizer.

@karuppiah7890
Copy link
Contributor

You mean the main source code? Or the main source code which is not tested with golang tests?

@tisonkun
Copy link
Contributor Author

@karuppiah7890 the main source code. If you find the main source code lack of test coverage, you can try to add one. It is highly encouraged.

@hawkingrei hawkingrei mentioned this issue Jan 4, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Jan 4, 2022
@hawkingrei
planner: migrate test-infra to testify for plan_stats_test (#31277)
8333b17 
ref #26857
@tisonkun tisonkun added the type/enhancement The issue or PR belongs to an enhancement. label Feb 17, 2022
@tisonkun tisonkun mentioned this issue Feb 24, 2022
Merged
ti-chi-bot pushed a commit that referenced this issue Feb 25, 2022
@tisonkun
planner/core: migrate test-infra to testify (#32597)
ac04f2e 
close #26857, close #28411
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner/core: migrate test-infra to testify tisonkun/tidb
2 participants
@karuppiah7890 @tisonkun