-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate test-infra to testify for session/pessimistic_test.go
#28325
Comments
/assign |
cc @hawkingrei @bb7133 @tiancaiamao So far, check_dev_2 use However, as we're migrating from go-check (pingcap/check) to testify, these flags doesn't work anymore and we'd better using a new approach to achieve the goal. I propose that we:
In this way, we're decouple with go-check's test filter mechanism. |
Another proposal is that we move these real tikv dependent tests to a new directory so that we don't mix up unit tests and those, as well as avoiding pushing all real tikv dependent tests under "session" pkg. |
Instead of modifying the CI pipeline, we can also handle those flag in code and thus decouple from CI changes. |
FYI you can refer to this file changes for my idea. But session test is still too stateful to debug...I'm unsure whether I make the test cases migrated right. |
I'm trying to running these tests with GitHub Actions so that I can handle the environment better. |
No description provided.
The text was updated successfully, but these errors were encountered: