Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for inspection_common_test.go #28589

Closed
Tracked by #26854
tisonkun opened this issue Oct 8, 2021 · 9 comments · Fixed by #30818
Closed
Tracked by #26854

migrate test-infra to testify for inspection_common_test.go #28589

tisonkun opened this issue Oct 8, 2021 · 9 comments · Fixed by #30818
Assignees
@bodhisatan
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Oct 8, 2021

No description provided.

@tisonkun tisonkun mentioned this issue Oct 8, 2021
Closed
75 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 8, 2021
@bodhisatan
Copy link
Contributor

/assign

@bodhisatan bodhisatan mentioned this issue Dec 16, 2021
Merged
12 tasks
@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

/assign

@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

As the day of the behind committer has passed 22 days, I think I can self-assigned it

@tisonkun
Copy link
Contributor Author

tisonkun commented Jan 7, 2022

@YufeiCh I think there is already a pull request for this #30818. You can review it instead of duplicate works.

@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

I agree with that, but the test suite in inspection_summary_test I want to migrate is related with this, so I want to migrate them together.

@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

@tisonkun the test suite is defined in inspection_summary_test, of course I will remove it after the migration, but this test suite is now used in inspection_common_test, the only way I can do without duplicated works is to move the definition of this test suite to inspection_common_test, and it will confict with the PR mentioned in this issue. So I want to migrate them all. But If you think move the test suite definition to inspection_common is better, I will do what you like.

@tisonkun
Copy link
Contributor Author

tisonkun commented Jan 7, 2022

@YufeiCh thanks for your information! I'm merging #30818 now, please rebase your work on the new master later.

@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

OK，Thanks for your quick reply.

@YufeiCh
Copy link
Contributor

YufeiCh commented Jan 7, 2022

/unassign

ti-chi-bot pushed a commit that referenced this issue Jan 8, 2022
@bodhisatan
executor/inspection_common_test.go: migrate test-infra (#30818)
b30e8dd 
close #28589
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bodhisatan bodhisatan

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor/inspection_common_test.go: migrate test-infra bodhisatan/tidb
3 participants
@tisonkun @YufeiCh @bodhisatan