Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for statement_context_test.go #28619

Closed
Tracked by #26854
tisonkun opened this issue Oct 8, 2021 · 5 comments · Fixed by #32486
Closed
Tracked by #26854

migrate test-infra to testify for statement_context_test.go #28619

tisonkun opened this issue Oct 8, 2021 · 5 comments · Fixed by #32486
Assignees
@feitian124
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Oct 8, 2021

No description provided.

@tisonkun tisonkun mentioned this issue Oct 8, 2021
Closed
75 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 8, 2021
@tisonkun tisonkun added the type/enhancement The issue or PR belongs to an enhancement. label Feb 17, 2022
@feitian124
Copy link
Contributor

/assign

@hawkingrei
Copy link
Member

@feitian124 Are you completing it?

@feitian124
Copy link
Contributor

feitian124 commented Feb 20, 2022 •
edited
Loading

not begin, what can i do for you? @hawkingrei

@hawkingrei
Copy link
Member

not begin, what can i do for you? @hawkingrei

It is so easy. I plan to finish it in this week.

@feitian124 feitian124 mentioned this issue Feb 21, 2022
Merged
@feitian124
Copy link
Contributor

yes, i start work from easy ones.
i assined myself about 10 issues and plan finish them this week.
if you are eager to finish some one in advance, feel free to take over and leave a message in the issue.
i will check issue status before start work.

and this one is finished, please check pr, thanks. @hawkingrei

ti-chi-bot pushed a commit that referenced this issue Feb 21, 2022
@feitian124
executor: migrate test-infra to testify for statement_context_test.go (…
3c64d10 
…#32486)

close #28619
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feitian124 feitian124

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: migrate test-infra to testify for statement_context_test.go feitian124/tidb
3 participants
@feitian124 @hawkingrei @tisonkun