Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate test-infra to testify for trace_test.go #28622

Closed
Tracked by #26854
tisonkun opened this issue Oct 8, 2021 · 1 comment · Fixed by #32104
Closed
Tracked by #26854

migrate test-infra to testify for trace_test.go #28622

tisonkun opened this issue Oct 8, 2021 · 1 comment · Fixed by #32104
Assignees
@johnhaxx7
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@tisonkun
Copy link
Contributor

tisonkun commented Oct 8, 2021

No description provided.

@tisonkun tisonkun mentioned this issue Oct 8, 2021
Closed
75 tasks
@tisonkun tisonkun added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Oct 8, 2021
@johnhaxx7
Copy link
Contributor

/assign

@johnhaxx7 johnhaxx7 mentioned this issue Feb 5, 2022
Merged
12 tasks
@hawkingrei hawkingrei added the type/enhancement The issue or PR belongs to an enhancement. label Feb 5, 2022
ti-chi-bot pushed a commit that referenced this issue Feb 6, 2022
@johnhaxx7
executor: migrate trace_test.go to testify (#32104)
27348d6 
close #28622
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnhaxx7 johnhaxx7

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: migrate trace_test.go to testify johnhaxx7/tidb
3 participants
@hawkingrei @johnhaxx7 @tisonkun