Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unstable test: builtin_string_test.go:2634 TestWeightString #29283

Closed
Tracked by #25899
djshow832 opened this issue Oct 31, 2021 · 4 comments · Fixed by #29276
Closed
Tracked by #25899

Unstable test: builtin_string_test.go:2634 TestWeightString #29283

djshow832 opened this issue Oct 31, 2021 · 4 comments · Fixed by #29276
Assignees
@tisonkun
Labels
affects-5.3 This bug affects 5.3.x versions. component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@djshow832
Copy link
Contributor

Bug Report

[2021-10-31T11:13:28.659Z] --- FAIL: TestWeightString (0.00s)

[2021-10-31T11:13:28.659Z]     builtin_string_test.go:2634: 

[2021-10-31T11:13:28.659Z]         	Error Trace:	builtin_string_test.go:2634

[2021-10-31T11:13:28.659Z]         	Error:      	Not equal: 

[2021-10-31T11:13:28.659Z]         	            	expected: "a "

[2021-10-31T11:13:28.659Z]         	            	actual  : "a"

[2021-10-31T11:13:28.659Z]         	            	

[2021-10-31T11:13:28.659Z]         	            	Diff:

[2021-10-31T11:13:28.659Z]         	            	--- Expected

[2021-10-31T11:13:28.659Z]         	            	+++ Actual

[2021-10-31T11:13:28.659Z]         	            	@@ -1 +1 @@

[2021-10-31T11:13:28.659Z]         	            	-a 

[2021-10-31T11:13:28.659Z]         	            	+a

[2021-10-31T11:13:28.659Z]         	Test:       	TestWeightString

See https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/42054/pipeline/
@djshow832 djshow832 added the type/bug The issue is confirmed as a bug. label Oct 31, 2021
This was referenced Oct 31, 2021
Closed
Merged
@tisonkun tisonkun mentioned this issue Nov 1, 2021
Merged
@tisonkun tisonkun self-assigned this Nov 1, 2021
@tisonkun
Copy link
Contributor

tisonkun commented Nov 1, 2021

@djshow832 you can take a look at #29276 . Sorry to miss moving TestCIWeightString to serial tests.

@unconsolable
Copy link
Contributor

Another occurrence https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/42258/pipeline

[2021-11-01T05:03:25.047Z] --- FAIL: TestWeightString (0.00s)
[2021-11-01T05:03:25.047Z]     builtin_string_test.go:2634: 
[2021-11-01T05:03:25.047Z]         	Error Trace:	builtin_string_test.go:2634
[2021-11-01T05:03:25.047Z]         	Error:      	Not equal: 
[2021-11-01T05:03:25.047Z]         	            	expected: "中    "
[2021-11-01T05:03:25.047Z]         	            	actual  : "中"
[2021-11-01T05:03:25.047Z]         	            	
[2021-11-01T05:03:25.047Z]         	            	Diff:
[2021-11-01T05:03:25.047Z]         	            	--- Expected
[2021-11-01T05:03:25.047Z]         	            	+++ Actual
[2021-11-01T05:03:25.047Z]         	            	@@ -1 +1 @@
[2021-11-01T05:03:25.047Z]         	            	-中    
[2021-11-01T05:03:25.047Z]         	            	+中
[2021-11-01T05:03:25.047Z]         	Test:       	TestWeightString

@github-actions
Copy link

github-actions bot commented Nov 2, 2021

Please check whether the issue should be labeled with 'affects-x.y' or 'fixes-x.y.z', and then remove 'needs-more-info' label.

@tiancaiamao tiancaiamao mentioned this issue Nov 3, 2021
Merged
12 tasks
@aytrack
Copy link
Contributor

aytrack commented Nov 29, 2021

Another occurrence https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/42258/pipeline

[2021-11-01T05:03:25.047Z] --- FAIL: TestWeightString (0.00s)
[2021-11-01T05:03:25.047Z]     builtin_string_test.go:2634: 
[2021-11-01T05:03:25.047Z]         	Error Trace:	builtin_string_test.go:2634
[2021-11-01T05:03:25.047Z]         	Error:      	Not equal: 
[2021-11-01T05:03:25.047Z]         	            	expected: "中    "
[2021-11-01T05:03:25.047Z]         	            	actual  : "中"
[2021-11-01T05:03:25.047Z]         	            	
[2021-11-01T05:03:25.047Z]         	            	Diff:
[2021-11-01T05:03:25.047Z]         	            	--- Expected
[2021-11-01T05:03:25.047Z]         	            	+++ Actual
[2021-11-01T05:03:25.047Z]         	            	@@ -1 +1 @@
[2021-11-01T05:03:25.047Z]         	            	-中    
[2021-11-01T05:03:25.047Z]         	            	+中
[2021-11-01T05:03:25.047Z]         	Test:       	TestWeightString

encounter again in ci https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_coverage/detail/tidb_ghpr_coverage/1382/pipeline

@bb7133 bb7133 mentioned this issue Jun 14, 2022
Merged
1 task
@bb7133 bb7133 added the affects-5.3 This bug affects 5.3.x versions. label Jun 15, 2022
ti-chi-bot pushed a commit that referenced this issue Jun 16, 2022
@bb7133
expression: fix 2 unstable test cases (#35371)
bae61dc 
close #29283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tisonkun tisonkun

Labels
affects-5.3 This bug affects 5.3.x versions. component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expression: migrate tests to testify tisonkun/tidb
6 participants
@bb7133 @ChenPeng2013 @aytrack @unconsolable @tisonkun @djshow832