Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pd config can't be auto resumed if lightning panic #31733

Closed
glorv opened this issue Jan 17, 2022 · 6 comments · Fixed by #31725
Closed

pd config can't be auto resumed if lightning panic #31733

glorv opened this issue Jan 17, 2022 · 6 comments · Fixed by #31725
Assignees
Labels
affects-6.0 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.

Comments

@glorv
Copy link
Contributor

glorv commented Jan 17, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

  1. Run tidb-lightning with local backend
  2. After tidb-lightning start running and pd-scheduler is patched, stop tidb-lightning process will kill -9

2. What did you expect to see? (Required)

The scheduler config should be restored to the origin value after 5min.

3. What did you see instead (Required)

The scheduler remained the changed value.

4. What is your TiDB version? (Required)

nightly

@glorv glorv added type/bug The issue is confirmed as a bug. severity/major component/lightning This issue is related to Lightning of TiDB. labels Jan 17, 2022
@glorv
Copy link
Contributor Author

glorv commented Jan 17, 2022

/cc @3pointer

@3pointer
Copy link
Contributor

I have a draft PR to fix this issue. #31725. but cannot verify in tests. because we cannot make sure the ttl works through api.

// update config with ttl
curl http://{PD_IP}/pd/api/v1/config?ttlSecond=100 -XPOST -d '{"schedule.max-merge-region-keys":0}'

// get config and found config still not changed.
curl http://{PD_IP}/pd/api/v1/config/schedule | grep max-merge-region-keys

  "max-merge-region-keys": 2000,

@3pointer
Copy link
Contributor

cc @rleungx, should PD provide an api to tell us the specified config's ttl worked?

@rleungx
Copy link
Member

rleungx commented Jan 18, 2022

Yes, we should. See tikv/pd#4596

@sleepymole
Copy link
Contributor

It is the same as #33546 and fixed by #33545.

@3pointer 3pointer reopened this May 9, 2022
@3pointer
Copy link
Contributor

3pointer commented May 9, 2022

it's not as same as scheduler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.0 component/lightning This issue is related to Lightning of TiDB. severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants