Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance task field for explain/explain analyze #33332

Closed
windtalker opened this issue Mar 23, 2022 · 0 comments · Fixed by #33333
Closed

Enhance task field for explain/explain analyze #33332

windtalker opened this issue Mar 23, 2022 · 0 comments · Fixed by #33333
Assignees
@windtalker
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@windtalker
Copy link
Contributor

Enhancement

Currently, the output of explain/explain analyze contains a column named task, it can be

  • root: the task is running in TiDB
  • cop[tiflash]: the task is runing in TiFlash via CopRequest
  • cop[tikv]: the task is running in TiKV via CopRequest
  • batchCop[tiflash]: the task is running in TiFlash via BatchCopRequest

However, since v5.0.0, TiDB/TiFlash support mpp, that is some tasks are actually running in TiFlash via MPPRequest, but task in the output of explain does not support this, even if the task is running in mpp mode, it still shows cop[tiflash] or batchCop[tiflash], this will make user confused, better to add a new task type mpp[tiflash] to show that the task is running in TiFlash via MPPRequest
@windtalker windtalker added the type/enhancement The issue or PR belongs to an enhancement. label Mar 23, 2022
@windtalker windtalker self-assigned this Mar 23, 2022
@windtalker windtalker mentioned this issue Mar 23, 2022
Merged
12 tasks
ti-chi-bot pushed a commit that referenced this issue Mar 29, 2022
@windtalker
executor: Enhance task field for explain/explain analyze (#33333)
c58e005 
close #33332
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@windtalker windtalker

Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: Enhance task field for explain/explain analyze windtalker/tidb
1 participant
@windtalker