Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rollup expand should support being converted to pb.expand2 #45179

Closed
AilinKid opened this issue Jul 5, 2023 · 0 comments · Fixed by #44973
Closed

rollup expand should support being converted to pb.expand2 #45179

AilinKid opened this issue Jul 5, 2023 · 0 comments · Fixed by #44973
Assignees
@AilinKid
Labels
severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@AilinKid
Copy link
Contributor

AilinKid commented Jul 5, 2023

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

current rollup physical Expand still sends the old version tipb.Expand, we should use the new version: tipb.Expand2

2. What did you expect to see? (Required)

should use tipb.Expand2

3. What did you see instead (Required)

nil pointer error.

4. What is your TiDB version? (Required)

master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AilinKid AilinKid

Labels
severity/minor sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner: physical expand support being converted to tipb.Expand2 AilinKid/tidb
1 participant
@AilinKid