Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: disable the stats information backup by default for sql command #48000

Closed
BornChanger opened this issue Oct 26, 2023 · 5 comments · Fixed by #48025
Closed

br: disable the stats information backup by default for sql command #48000

BornChanger opened this issue Oct 26, 2023 · 5 comments · Fixed by #48025
Assignees
@YuJuncen
Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.

Comments

@BornChanger
Copy link
Contributor

BornChanger commented Oct 26, 2023 •
edited
Loading

Enhancement

Stats information backup needs to call dumpStatsToJson function which costs a lot of memory especially when there are a lot of database objects.

For br clp, flag ignore-stats is turned on by default, while it's not for backup sql command. So, backup could bring OOM issues.

We need to sync the behavior to as the clp, and also expose the parameter to sql command.

Via this issue, we also needs to sync up the default flags including use-checkpoint.
@BornChanger BornChanger added the type/enhancement The issue or PR belongs to an enhancement. label Oct 26, 2023
@BornChanger
Copy link
Contributor Author

/component br

@ti-chi-bot ti-chi-bot bot added the component/br This issue is related to BR of TiDB. label Oct 27, 2023
@BornChanger BornChanger mentioned this issue Oct 27, 2023
Merged
5 tasks
@BornChanger
Copy link
Contributor Author

/assign @YuJuncen

@BornChanger
Copy link
Contributor Author

/label affects-7.5

@BornChanger
Copy link
Contributor Author

BornChanger commented Nov 7, 2023 •
edited
Loading

/label affects-6.5

@BornChanger
Copy link
Contributor Author

/label affects-7.1

ti-chi-bot bot pushed a commit that referenced this issue Nov 8, 2023
@YuJuncen
executor/brie: use the default value from flags (#48025)
632cd84 
close #48000
This was referenced Nov 8, 2023
Merged
Merged
Merged
ti-chi-bot bot pushed a commit that referenced this issue Nov 8, 2023
@ti-chi-bot
executor/brie: use the default value from flags (#48025) (#48440)
9511113 
close #48000
ti-chi-bot bot pushed a commit that referenced this issue Nov 24, 2023
@ti-chi-bot
executor/brie: use the default value from flags (#48025) (#48441)
0ad5d11 
close #48000
ti-chi-bot bot pushed a commit that referenced this issue Dec 8, 2023
@ti-chi-bot
executor/brie: use the default value from flags (#48025) (#48442)
1725235 
close #48000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YuJuncen YuJuncen

Labels
affects-6.5 affects-7.1 affects-7.5 component/br This issue is related to BR of TiDB. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor/brie: use the default value from flags YuJuncen/tidb
2 participants
@YuJuncen @BornChanger