Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

please add unnecessary untracked files to gitignore and should clean them up in make clean #49070

Closed
siddontang opened this issue Nov 30, 2023 · 0 comments · Fixed by #49314
Closed

please add unnecessary untracked files to gitignore and should clean them up in make clean #49070

siddontang opened this issue Nov 30, 2023 · 0 comments · Fixed by #49314
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.

Comments

@siddontang
Copy link
Member

Enhancement

After I failed to run make test or make ut, I found that following paths exists and you can see that git treats them as untracked files.

Untracked files:
  (use "git add <file>..." to include in what will be committed)
	pkg/domain/extract/
	pkg/executor/test/executor/replayer/
	pkg/server/handler/optimizor/replayer/
	test_coverage/
	tests/integrationtest/replayer/

so it is better to add them in .gitignore file and to remove them with make clean
@siddontang siddontang added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 30, 2023
@yoshikipom yoshikipom mentioned this issue Dec 10, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 11, 2023
@yoshikipom
*: add unnecessary untracked files to .gitignore and clean up them (#…
4eada20 
…49314)

close #49070
@bb7133 bb7133 mentioned this issue Dec 13, 2023
Merged
5 tasks
ti-chi-bot bot pushed a commit that referenced this issue Dec 21, 2023
@bb7133
*: delete '.test.bin' files for 'make clean' (#49447)
a022451 
ref #49070
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

*: add unnecessary untracked files to .gitignore and clean up them yoshikipom/tidb
1 participant
@siddontang