Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: control Chunk size for TableReader&IndexReader&IndexLookup #10169

Merged
merged 5 commits into from
Apr 17, 2019
Merged

executor: control Chunk size for TableReader&IndexReader&IndexLookup #10169

merged 5 commits into from
Apr 17, 2019

Conversation

qw4990
Copy link
Contributor

@qw4990 qw4990 commented Apr 16, 2019

cherry-pick for #9452

@qw4990
Copy link
Contributor Author

qw4990 commented Apr 16, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@qw4990 qw4990 requested review from zz-jason and lysu April 16, 2019 08:37
@qw4990 qw4990 changed the title Release 2.1 chunk readers executor: control Chunk size for TableReader&IndexReader&IndexLookup Apr 16, 2019
zz-jason
zz-jason reviewed Apr 17, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 17, 2019
lysu
lysu approved these changes Apr 17, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 17, 2019
@jackysp jackysp merged commit 8bbcdd8 into pingcap:release-2.1 Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zz-jason zz-jason zz-jason left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qw4990 @lysu @zz-jason @jackysp