Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix csv parser (#9005) #10269

Merged
merged 2 commits into from
Apr 26, 2019
Merged

executor: fix csv parser (#9005) #10269

merged 2 commits into from
Apr 26, 2019

Conversation

imtbkcat
Copy link

What problem does this PR solve?

cherry-pick #9005

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

@jackysp
Copy link
Member

jackysp commented Apr 25, 2019

/run-all-tests tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp
Copy link
Member

jackysp commented Apr 25, 2019

/run-integration-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

@jackysp
Copy link
Member

jackysp commented Apr 25, 2019

/run-common-test tidb-test=release-2.1 tikv=release-2.1 pd=release-2.1

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@jackysp PTAL

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 26, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp merged commit b51f531 into pingcap:release-2.1 Apr 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants