Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session: add the transaction commit time to slow log #10294

Merged
merged 3 commits into from
Apr 29, 2019

Conversation

jackysp
Copy link
Member

@jackysp jackysp commented Apr 28, 2019

What problem does this PR solve?

The commit time and the statement execution time should be merged together in slow log.

What is changed and how it works?

Record the slow log in runStmt.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

  • Increased code complexity

Related changes

  • Need to cherry-pick to the release branch

@jackysp jackysp added the type/enhancement The issue or PR belongs to an enhancement. label Apr 28, 2019
@jackysp
Copy link
Member Author

jackysp commented Apr 28, 2019

/run-all-tests

@jackysp jackysp requested review from crazycs520 and lysu April 28, 2019 11:27
@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0185%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8219%   77.8404%   +0.0185%     
================================================
  Files           410        410                
  Lines         84728      84695        -33     
================================================
- Hits          65937      65927        -10     
+ Misses        13861      13845        -16     
+ Partials       4930       4923         -7

1 similar comment
@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0185%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8219%   77.8404%   +0.0185%     
================================================
  Files           410        410                
  Lines         84728      84695        -33     
================================================
- Hits          65937      65927        -10     
+ Misses        13861      13845        -16     
+ Partials       4930       4923         -7

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10294 into master will increase coverage by 0.0234%.
The diff coverage is 100%.

@@               Coverage Diff                @@
##             master     #10294        +/-   ##
================================================
+ Coverage   77.8087%   77.8322%   +0.0234%     
================================================
  Files           410        410                
  Lines         84966      84704       -262     
================================================
- Hits          66111      65927       -184     
+ Misses        13909      13854        -55     
+ Partials       4946       4923        -23

@coocood
Copy link
Member

coocood commented Apr 28, 2019

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tiancaiamao
Copy link
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants