expression: let PushDownNot does not change the argument
#10363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
winoros
reviewed
May 6, 2019
| @@ -395,7 +395,7 @@ func (s *testPlanSuite) TestSimplifyOuterJoin(c *C) { | |||
| }, | |||
| { | |||
| sql: "select * from t t1 left join t t2 on t1.b = t2.b where not (t1.c > 1 and t2.c > 1);", | |||
| best: "Join{DataScan(t1)->DataScan(t2)}(test.t1.b,test.t2.b)->Sel([not(and(le(test.t1.c, 1), le(test.t2.c, 1)))])->Projection", | |||
There was a problem hiding this comment.
So this one is wrong previously? 😂
Codecov Report
@@ Coverage Diff @@
## master #10363 +/- ##
================================================
+ Coverage 77.6648% 77.6818% +0.0169%
================================================
Files 411 411
Lines 85475 85437 -38
================================================
- Hits 66384 66369 -15
+ Misses 14128 14114 -14
+ Partials 4963 4954 -9 |
alivxxx
added
status/all tests passed
status/LGT1
XuHuaiyu
reviewed
May 6, 2019
XuHuaiyu
approved these changes
May 6, 2019
XuHuaiyu
added
status/LGT2
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
May 8, 2019
ngaut
pushed a commit
that referenced
this pull request
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix #10344
What is changed and how it works?
PushDownNotdirectly change its argumentexpr, and if theexpris referenced in other places, it will cause wrong results. This PR keeps the argument unchanged.Check List
Tests
Code changes
Side effects
Related changes