planner: ByItem should filter NULL out
#10488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10488 +/- ##
================================================
- Coverage 77.3317% 77.3274% -0.0043%
================================================
Files 413 413
Lines 87316 87273 -43
================================================
- Hits 67523 67486 -37
+ Misses 14604 14597 -7
- Partials 5189 5190 +1 |
alivxxx
reviewed
May 16, 2019
XuHuaiyu
reviewed
May 20, 2019
| @@ -201,6 +202,14 @@ func (s *testPlanSuite) TestDAGPlanBuilderSimpleCase(c *C) { | |||
| sql: "select * from ((SELECT 1 a,6 b) UNION (SELECT 2,5) UNION (SELECT 2, 4) ORDER BY 1) t order by 1, 2", | |||
| best: "UnionAll{Dual->Projection->Dual->Projection->Dual->Projection}->HashAgg->Sort->Sort", | |||
| }, | |||
| { | |||
| sql: "select * from (select *, NULL as xxx from t) t order by xxx", | |||
There was a problem hiding this comment.
This test can work well without this commit.
Maybe we need to build another case?
eurekaka
reviewed
May 20, 2019
eurekaka
added
status/LGT2
|
@winoros please resolve conflicts. |
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
partially fix #10478
and fix #10456
What is changed and how it works?
filter NULL value in planner phase.
Check List
Tests
Related changes