Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: fix split table bug #10761

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

Fix split table by panic.

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

executor/executor_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 11, 2019

Codecov Report

Merging #10761 into master will increase coverage by 0.0487%.
The diff coverage is 100%.

@@               Coverage Diff               @@
##             master    #10761        +/-   ##
===============================================
+ Coverage   79.8572%   79.906%   +0.0487%     
===============================================
  Files           415       415                
  Lines         88270     88305        +35     
===============================================
+ Hits          70490     70561        +71     
+ Misses        12572     12540        -32     
+ Partials       5208      5204         -4

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants