Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: remove expired keys on PD (#10406) #11014

Merged
merged 7 commits into from
Jul 5, 2019
Merged

ddl: remove expired keys on PD (#10406) #11014

merged 7 commits into from
Jul 5, 2019

Conversation

zimulala
Copy link
Contributor

@zimulala zimulala commented Jul 1, 2019

Cherry-pick #10406 to v3.0

@zimulala
Copy link
Contributor Author

zimulala commented Jul 1, 2019

/run-all-tests

@zimulala
Copy link
Contributor Author

zimulala commented Jul 1, 2019

/run-common-test
/run-integration-common-test

crazycs520
crazycs520 reviewed Jul 1, 2019
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zimulala zimulala added status/all tests passed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 2, 2019
@zimulala
Copy link
Contributor Author

zimulala commented Jul 2, 2019

PTAL @bb7133

bb7133
bb7133 approved these changes Jul 2, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Jul 2, 2019

/run-all-tests tikv=release-3.0 pd=release-3.0

@bb7133 bb7133 added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 2, 2019
@zimulala zimulala merged commit 8493e45 into pingcap:release-3.0 Jul 5, 2019
@zimulala zimulala deleted the zimuxia/rm-etcd-key branch July 5, 2019 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zimulala @bb7133 @crazycs520 @zz-jason