executor: handle unsigned primary key for fast analyze #11074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alivxxx
added
type/bugfix
Codecov Report
@@ Coverage Diff @@
## master #11074 +/- ##
================================================
- Coverage 80.9954% 80.9081% -0.0874%
================================================
Files 419 418 -1
Lines 89384 89195 -189
================================================
- Hits 72397 72166 -231
- Misses 11759 11795 +36
- Partials 5228 5234 +6 |
winoros
approved these changes
Jul 4, 2019
alivxxx
added
status/LGT2
|
/run-all-tests |
alivxxx
added a commit
to alivxxx/tidb
that referenced
this pull request
Jul 5, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jul 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Currently, fast analyze treat all handle column as signed int64, it will produce wrong stats if there are values greater than
MaxInt64.What is changed and how it works?
If the primary key has unsigned flag, convert the handle id to unsigned uint64.
Check List
Tests
Code changes
Side effects
Related changes