Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CONVERT_TZ should return NULL if its arguments are invalid. (#11161) (#11176) #11359

Conversation

SunRunAway
Copy link
Contributor

Automated cherry pick of #11176 on release-3.0.
#11176: CONVERT_TZ should return NULL if its arguments are invalid.

@SunRunAway
Copy link
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@SunRunAway SunRunAway changed the title CONVERT_TZ should return NULL if its arguments are invalid. (#11161) CONVERT_TZ should return NULL if its arguments are invalid. (#11161) (#11176) Jul 22, 2019
@SunRunAway
Copy link
Contributor Author

/run-all-tests tikv=release-3.0 pd=release-3.0 tidb-test=release-3.0

@SunRunAway SunRunAway requested review from qw4990, lzmhhh123 and zz-jason and removed request for qw4990 and lzmhhh123 July 22, 2019 07:02
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2019
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 23, 2019
@zz-jason zz-jason merged commit aa4b386 into pingcap:release-3.0 Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants