[3.0] ddl: error or skip unsupported partition-related DDLs (#10672) #11373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* ddl: error or skip unsupported partition-related DDLs * go.mod: stop replacing parser since the PR is merged * ddl: addressed comment
kennytm
force-pushed
the
cherry-picks-partition-by-to-3.0
branch
from
90e472f
to
018924b
Compare
|
LGTM @crazycs520 |
zz-jason
requested review from
crazycs520 and
winkyao
and removed request for
crazycs520
|
@kennytm seems CI is failed, could you merge master and fix ci firstly? after that we can process on this PR. |
zz-jason
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-picks #10672 to release-3.0.
Additionally, included the test case shown in #10672 (comment)
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes