stats: handle feedback updates for topn items #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11434 +/- ##
===========================================
Coverage 81.4066% 81.4066%
===========================================
Files 424 424
Lines 91226 91226
===========================================
Hits 74264 74264
Misses 11635 11635
Partials 5327 5327 |
winoros
reviewed
Jul 25, 2019
|
/run-all-tests |
alivxxx
added
status/LGT2
|
cherry pick to release-3.0 in PR #11507 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support update count of topn when using feedback.
What is changed and how it works?
Add a new field in
queryFeedbackto store the raw feedback values so it can update the topn items.Check List
Tests
Code changes
Side effects
Related changes