*: record index name in the slow log instead of index id #11795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11795 +/- ##
================================================
- Coverage 81.6878% 81.4352% -0.2527%
================================================
Files 435 434 -1
Lines 94216 93478 -738
================================================
- Hits 76963 76124 -839
- Misses 11795 11897 +102
+ Partials 5458 5457 -1 |
Codecov Report
@@ Coverage Diff @@
## master #11795 +/- ##
================================================
+ Coverage 81.4689% 81.5597% +0.0907%
================================================
Files 435 435
Lines 94123 94467 +344
================================================
+ Hits 76681 77047 +366
+ Misses 11955 11937 -18
+ Partials 5487 5483 -4 |
zz-jason
reviewed
Aug 20, 2019
| @@ -131,7 +131,7 @@ type StatementContext struct { | |||
| MemTracker *memory.Tracker | |||
| RuntimeStatsColl *execdetails.RuntimeStatsColl | |||
| TableIDs []int64 | |||
There was a problem hiding this comment.
- How about using table names as well?
- How about using the
table_name:index_nameformat to display table and index names?
There was a problem hiding this comment.
tableIDs is not be printed in the slow log.
There was a problem hiding this comment.
If we do not print the table id, how do we know which table is accessed with an index if there are multiple tables doing the join operation?
There was a problem hiding this comment.
How about store table_name:index_name in indexNames?
zz-jason
reviewed
Aug 21, 2019
zimulala
reviewed
Aug 22, 2019
ngaut
added
the
status/can-merge
|
/run-all-tests |
|
@crazycs520 merge failed. |
|
/run-all-tests |
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Sep 6, 2019
crazycs520
added a commit
to crazycs520/tidb
that referenced
this pull request
Sep 6, 2019
zimulala
pushed a commit
that referenced
this pull request
Sep 9, 2019
zimulala
pushed a commit
that referenced
this pull request
Sep 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Index ID is not readable, and we can't know the index id
1belonged to which table.In This PR:
It will record
tableName:indexNamein slow log.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release Note