Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine pre-split region logic (#11794) #11797

Merged
merged 2 commits into from
Aug 26, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Aug 20, 2019

cherry-pick #11794 to release-2.1


What problem does this PR solve?

The original logic of pre_split_region will split 2^(pre_split_region -1) regions. It was strange for the user to understand and remember it.

This PR will simply split 2^(pre_split_region) regions when create table with pre_split_region.

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release Note

  • Change pre_split_regions logic for easy to understand and remember.

@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 20, 2019

/run-all-tests

@crazycs520
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/can-merge Indicates a PR has been approved by a committer. label Aug 26, 2019
@sre-bot
Copy link
Contributor Author

sre-bot commented Aug 26, 2019

Sorry @bb7133, you don't have permission to trigger auto merge event on this branch.

@winkyao winkyao merged commit 2a067ee into pingcap:release-2.1 Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. type/usability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants