Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: implement vectorized evaluation for builtinGreatestDecimalSig #12077

Merged
merged 12 commits into from
Sep 9, 2019
Merged

expression: implement vectorized evaluation for builtinGreatestDecimalSig #12077

merged 12 commits into from
Sep 9, 2019

Conversation

Reminiscent
Copy link
Contributor

What problem does this PR solve?

Implement vectorized evaluation for builtinGreatestDecimalSig.

What is changed and how it works?

BenchmarkVectorizedBuiltinFunc/builtinGreatestDecimalSig-VecBuiltinFunc-4          50000             40570 ns/op
BenchmarkVectorizedBuiltinFunc/builtinGreatestDecimalSig-NonVecBuiltinFunc-4       30000             55793 ns/op

Check List

Tests

  • Unit test

@codecov
Copy link

codecov bot commented Sep 9, 2019 •
edited
Loading

Codecov Report

Merging #12077 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #12077   +/-   ##
===========================================
  Coverage   81.5013%   81.5013%           
===========================================
  Files           449        449           
  Lines         95969      95969           
===========================================
  Hits          78216      78216           
  Misses        12185      12185           
  Partials       5568       5568

@qw4990 qw4990 mentioned this pull request Sep 9, 2019
Closed
SunRunAway
SunRunAway reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 previously approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qw4990
Copy link
Contributor

qw4990 commented Sep 9, 2019

@Reminiscent Please resolve conflicts.

@zz-jason zz-jason removed their request for review September 9, 2019 10:50
zz-jason
zz-jason previously approved these changes Sep 9, 2019
View reviewed changes
Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. labels Sep 9, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

/run-all-tests

@zz-jason
Copy link
Member

zz-jason commented Sep 9, 2019

to #12058

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

@Reminiscent merge failed.

@zz-jason
Copy link
Member

zz-jason commented Sep 9, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Sep 9, 2019

/run-all-tests

qw4990
qw4990 approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Reminiscent Reminiscent merged commit 0f24346 into pingcap:master Sep 9, 2019
@qw4990 qw4990 mentioned this pull request Sep 10, 2019
Closed
30 tasks
@Reminiscent Reminiscent deleted the greatestDecimal branch December 24, 2019 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

@zz-jason zz-jason zz-jason left review comments

@XuHuaiyu XuHuaiyu Awaiting requested review from XuHuaiyu

@wshwsh12 wshwsh12 Awaiting requested review from wshwsh12

Assignees
No one assigned
Labels
component/expression status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Reminiscent @qw4990 @sre-bot @zz-jason @SunRunAway