support hash join in new plan #1234

hanfei19910905 · 2016-05-16T03:26:15Z

support hash join

zimulala · 2016-05-16T04:24:50Z

optimizer/plan/new_plans.go

@@ -0,0 +1,45 @@
+// Copyright 2015 PingCAP, Inc.


2015 -> 2016

coocood · 2016-05-16T07:33:49Z

You can add a function in plan like

func AddParentChildren(parent, children Plan) {
    parent.AddChildren(children)
    children.AddParent(parent)
}

So you will never forget to call one of them.

coocood · 2016-05-16T08:35:41Z

optimizer/plan/newplanbuilder.go

+	if sel.From != nil {
+		p = b.buildNewSinglePathPlan(sel.From.TableRefs)
+		if sel.Where != nil {
+			p = b.buildFilter(p, sel.Where)


If where is all pushed down, this would be redundant?

we build filter first and then apply predicate pushing down. when finishing it, this filter can be removed.

coocood · 2016-05-17T05:02:33Z

optimizer/plan/newplanbuilder.go

+}
+
+func (ce *columnsExtractor) Leave(expr ast.Node) (ret ast.Node, ok bool) {
+	return expr, false


return expr, true

shenli · 2016-05-17T14:54:36Z

Add a simple benchmark for join like: https://github.com/pingcap/tidb/blob/master/bench_test.go#L160

shenli · 2016-05-17T14:58:02Z

executor/builder.go

+	case plan.LeftOuterJoin:
+		e.outter = true
+		e.leftSmall = false
+		big, small = 0, 1


What's this 0 and 1 mean? Please add comment or use const.

e.leftSmall is enough for deciding which child will be used for smallExec. So big/small is redundant.

coocood · 2016-05-18T07:42:36Z

optimizer/plan/predicate_push_down.go

+			}
+		}
+	}
+	return inNode, false


return inNode, true

coocood · 2016-05-19T07:09:21Z

LGTM

hanfei19910905 · 2016-05-19T07:09:52Z

@shenli PATL

zimulala · 2016-05-19T07:15:41Z

optimizer/plan/planbuilder.go

 )

 // Error codes.
 const (
 	CodeUnsupportedType terror.ErrCode = 1
+	SystemInternalError terror.ErrCode = 1


shenli · 2016-05-19T07:28:52Z

LGTM

zimulala · 2016-05-19T07:30:43Z

executor/executor_test.go

@@ -1,4 +1,4 @@
-// Copyright 2015 PingCAP, Inc.


2016 -> 2015 ?

…pingcap#1234)

hanfei1991 added 2 commits May 16, 2016 11:20

support hash join.

c1a557f

Merge branch 'master' into hanfei/rewrite_plan

b5355a9

zimulala reviewed May 16, 2016
View reviewed changes

optimizer/plan/new_plans.go

@@ -0,0 +1,45 @@

// Copyright 2015 PingCAP, Inc.

Copy link

Contributor

zimulala May 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2015 -> 2016

coocood reviewed May 16, 2016
View reviewed changes

fix some errors

b7338aa

coocood reviewed May 17, 2016
View reviewed changes

hanfei1991 added 2 commits May 17, 2016 20:52

add test for predicate push down

ac5757b

change substitutor...

4915b5b

hanfei19910905 force-pushed the hanfei/rewrite_plan branch from ec90efb to 4915b5b Compare May 17, 2016 13:24

shenli reviewed May 17, 2016
View reviewed changes

change comment

ebf166d

coocood reviewed May 18, 2016
View reviewed changes

optimizer/plan/predicate_push_down.go

}

}

}

return inNode, false

Copy link

Member

coocood May 18, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

return inNode, true

hanfei19910905 force-pushed the hanfei/rewrite_plan branch from 5bdafd3 to 3670a3d Compare May 19, 2016 06:31

zimulala reviewed May 19, 2016
View reviewed changes

hanfei19910905 force-pushed the hanfei/rewrite_plan branch 2 times, most recently from 496c6a1 to 9b5a3b1 Compare May 19, 2016 07:25

zimulala reviewed May 19, 2016
View reviewed changes

executor/executor_test.go

@@ -1,4 +1,4 @@

// Copyright 2015 PingCAP, Inc.

Copy link

Contributor

zimulala May 19, 2016 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2016 -> 2015 ?

fix bug.

b526229

hanfei19910905 force-pushed the hanfei/rewrite_plan branch from 9b5a3b1 to b526229 Compare May 19, 2016 07:32

Merge branch 'master' into hanfei/rewrite_plan

9c210da

hanfei19910905 merged commit 228f1d7 into master May 19, 2016

hanfei19910905 deleted the hanfei/rewrite_plan branch May 19, 2016 07:43

sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019

3pointer pushed a commit to 3pointer/tidb that referenced this pull request Jun 28, 2021

cmd/br/debug.go: use br/pkg/mock/mockid instead of pd/pkg/mock/mockid (…

7c82cae

…pingcap#1234)

ti-chi-bot bot mentioned this pull request May 15, 2023

txn: Add txn state's view #22908

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

support hash join in new plan #1234

support hash join in new plan #1234

hanfei19910905 commented May 16, 2016

zimulala May 16, 2016

coocood commented May 16, 2016

coocood May 16, 2016

hanfei19910905 May 16, 2016 •

edited

Loading

coocood May 17, 2016

shenli commented May 17, 2016

shenli May 17, 2016

shenli May 18, 2016 •

edited

Loading

coocood May 18, 2016

coocood commented May 19, 2016

hanfei19910905 commented May 19, 2016

zimulala May 19, 2016

shenli commented May 19, 2016

zimulala May 19, 2016 •

edited

Loading

support hash join in new plan #1234

support hash join in new plan #1234

Conversation

hanfei19910905 commented May 16, 2016

zimulala May 16, 2016

Choose a reason for hiding this comment

coocood commented May 16, 2016

coocood May 16, 2016

Choose a reason for hiding this comment

hanfei19910905 May 16, 2016 • edited Loading

Choose a reason for hiding this comment

coocood May 17, 2016

Choose a reason for hiding this comment

shenli commented May 17, 2016

shenli May 17, 2016

Choose a reason for hiding this comment

shenli May 18, 2016 • edited Loading

Choose a reason for hiding this comment

coocood May 18, 2016

Choose a reason for hiding this comment

coocood commented May 19, 2016

hanfei19910905 commented May 19, 2016

zimulala May 19, 2016

Choose a reason for hiding this comment

shenli commented May 19, 2016

zimulala May 19, 2016 • edited Loading

Choose a reason for hiding this comment

hanfei19910905 May 16, 2016 •

edited

Loading

shenli May 18, 2016 •

edited

Loading

zimulala May 19, 2016 •

edited

Loading