Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

types/data: the bit data type should be treat as uint64 (#11951) #12423

Merged
merged 5 commits into from
Sep 27, 2019
Merged

types/data: the bit data type should be treat as uint64 (#11951) #12423

merged 5 commits into from
Sep 27, 2019

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Sep 26, 2019

cherry-pick #11951 to release-3.0

What problem does this PR solve?

Fix #11895
the -1 can't be insert into a bit column.

What is changed and how it works?

  1. when convert to mysql bit, mapped it to unsigned int.
  2. the error is wrong (it should be data too long instead of out of range)

Check List

Tests

  • Unit test -- added test cases

@sre-bot
Copy link
Contributor Author

sre-bot commented Sep 26, 2019

/run-all-tests

@sre-bot sre-bot mentioned this pull request Sep 26, 2019
Merged
@sre-bot sre-bot added contribution This PR is from a community contributor. type/3.0 cherry-pick type/bugfix This PR fixes a bug. labels Sep 26, 2019
SunRunAway
SunRunAway reviewed Sep 26, 2019
View reviewed changes
Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

qw4990
qw4990 approved these changes Sep 27, 2019
View reviewed changes
Copy link
Contributor

@qw4990 qw4990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit b736230 into pingcap:release-3.0 Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SunRunAway SunRunAway SunRunAway left review comments

@qw4990 qw4990 qw4990 approved these changes

@zz-jason zz-jason Awaiting requested review from zz-jason

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sre-bot @SunRunAway @qw4990 @zz-jason @gaoxingliang