Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan: support ? in Order By / Group By / Limit Offset clauses (#8206) #12514

Merged
merged 7 commits into from
Oct 14, 2019
Merged

plan: support ? in Order By / Group By / Limit Offset clauses (#8206) #12514

merged 7 commits into from
Oct 14, 2019

Conversation

zz-jason
Copy link
Member

@zz-jason zz-jason commented Oct 3, 2019 •
edited
Loading

cherry pick #8206 to release-2.1

NOTE: Should be merged together with pingcap/parser#569

What problem does this PR solve?

Fix #8153

What is changed and how it works?

  • Modify parser.ByItem to support ast.ParamMarkerExpr
  • The prepared statements having parameters in OrderByClause or GroupByClause aren't cached

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change
  • Has persistent data change (i.e., parser)

Side effects

  • No

Related changes

  • Need to update the parser repository (i.e., the parser PR #27)

@zz-jason zz-jason added type/bugfix This PR fixes a bug. sig/planner SIG: Planner type/2.1 cherry-pick labels Oct 3, 2019
alivxxx
alivxxx reviewed Oct 9, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason requested a review from winoros October 14, 2019 11:55
winoros
winoros reviewed Oct 14, 2019
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@zz-jason zz-jason removed the request for review from eurekaka October 14, 2019 12:04
winoros
winoros approved these changes Oct 14, 2019
View reviewed changes
Copy link
Member

@winoros winoros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@winoros
Copy link
Member

winoros commented Oct 14, 2019

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

Sorry @winoros, you don't have permission to trigger auto merge event on this branch.

@zz-jason
Copy link
Member Author

/merge

@sre-bot sre-bot added the status/can-merge Indicates a PR has been approved by a committer. label Oct 14, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

Your auto merge job has been accepted, waiting for 12695

@zz-jason zz-jason added status/LGT2 Indicates that a PR has LGTM 2. and removed status/can-merge Indicates a PR has been approved by a committer. labels Oct 14, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Oct 14, 2019

/run-all-tests

@zz-jason zz-jason merged commit 9628e59 into pingcap:release-2.1 Oct 14, 2019
@zz-jason zz-jason deleted the cherrypick/pr/8206 branch October 14, 2019 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@winoros winoros winoros approved these changes

Assignees
No one assigned
Labels
sig/planner SIG: Planner status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zz-jason @winoros @sre-bot @alivxxx @dbjoa