Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: support next chunk for slow_query #14754

Merged
merged 11 commits into from
Feb 18, 2020
Merged

*: support next chunk for slow_query #14754

merged 11 commits into from
Feb 18, 2020

Conversation

crazycs520
Copy link
Contributor

Signed-off-by: crazycs crazycs520@gmail.com

What problem does this PR solve?

This PR is the step 1 of #14748.

What is changed and how it works?

  • Mostly, this PR move get slow_query data logic from infoschema pkg to executor pkg, this for supporting Next chunk.
  • Append error instead return error when parse slow log error. This is good for usability.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

@crazycs520
*: support next chunk for slow_query
c90a781 
Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520
refine code
41b9c3b 
Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520 crazycs520 requested a review from a team as a code owner February 12, 2020 14:05
@ghost ghost requested review from eurekaka and winoros and removed request for a team February 12, 2020 14:05
@crazycs520 crazycs520 added the type/enhancement The issue or PR belongs to an enhancement. label Feb 12, 2020
@crazycs520
Copy link
Contributor Author

/run-all-tests

@eurekaka eurekaka removed their request for review February 12, 2020 14:12
@reafans
Copy link
Contributor

reafans commented Feb 13, 2020

/run-all-tests

reafans
reafans reviewed Feb 18, 2020
View reviewed changes
executor/slow_query.go Outdated Show resolved Hide resolved
AilinKid
AilinKid reviewed Feb 18, 2020
View reviewed changes
executor/slow_query.go Show resolved Hide resolved
executor/slow_query.go Outdated Show resolved Hide resolved
infoschema/tables.go Outdated Show resolved Hide resolved
crazycs520 and others added 3 commits February 18, 2020 14:48
@crazycs520 @AilinKid
Update executor/slow_query.go
1540257 
Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
@crazycs520
address comment
8aee759 
Signed-off-by: crazycs <crazycs520@gmail.com>
@crazycs520
Merge branch 'master' of https://github.com/pingcap/tidb into slow-qu…
8578c25 
…ery-move
AilinKid
AilinKid reviewed Feb 18, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reafans
Copy link
Contributor

reafans commented Feb 18, 2020

/run-all-tests

@reafans
Copy link
Contributor

reafans commented Feb 18, 2020

lgtm

@reafans reafans added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 18, 2020
@reafans reafans added the status/can-merge Indicates a PR has been approved by a committer. label Feb 18, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented Feb 18, 2020

@crazycs520 merge failed.

@crazycs520
Copy link
Contributor Author

/run-unit-test

@crazycs520 crazycs520 merged commit db65a02 into pingcap:master Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@reafans reafans reafans approved these changes

@winoros winoros Awaiting requested review from winoros

Assignees
No one assigned
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement. type/usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @reafans @sre-bot @AilinKid