executor: make SLOW_QUERY support query slow log at any time #14840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
ghost
requested review from
eurekaka and
francis0407
and removed request for
a team
Signed-off-by: crazycs <crazycs520@gmail.com>
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
lonng
reviewed
Feb 19, 2020
AilinKid
reviewed
Feb 19, 2020
crazycs520
commented
Feb 19, 2020
There was a problem hiding this comment.
Already rename max_num to maxLineNum.
why not just seek cursor to a big value and readLine from up to the end?
Because the big value was hard to define. The size plan and query is unpredictable.
But the max line is certain, currently, 1 slow log won't more than 128 line.
Signed-off-by: crazycs <crazycs520@gmail.com>
reafans
reviewed
Feb 19, 2020
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
Signed-off-by: crazycs <crazycs520@gmail.com>
…into slow-query-more
|
Dear contributor, the first Performance challenge program has been closed. But you can still contribute to this issue and we appreciate your contribution. |
Signed-off-by: crazycs <crazycs520@gmail.com>
Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
Co-Authored-By: Arenatlx <ailinsilence4@gmail.com>
reafans
added
status/LGT2
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR is step 2 of #14748.
SLOW_QUERYsupport queryslow-logat any time.What is changed and how it works?
Since both
slow-logfiles have the same name prefix, then we can know which file is slow-log.But we can't always parse the all slow-log files, It will too slow. Since TiDB already has the
memtable_predicate_extracctor, We can get the query time range, and then locate slow-log files to parse based on the time range.Check List
Tests
Code changes
Side effects
Related changes
Release note