dml: support default expression cache when insert #15216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
AilinKid
changed the title
github-actions
bot
added
sig/sql-infra
Codecov Report
@@ Coverage Diff @@
## master #15216 +/- ##
===========================================
Coverage ? 80.3768%
===========================================
Files ? 502
Lines ? 133857
Branches ? 0
===========================================
Hits ? 107590
Misses ? 17827
Partials ? 8440 |
djshow832
reviewed
Mar 9, 2020
executor/insert_common.go
Outdated
| val types.Datum | ||
| // default expr like `nextval(seq)` should be evaluated row by row. |
There was a problem hiding this comment.
How are other default expressions implemented? e.g. current_timestamp().
There was a problem hiding this comment.
insert into (now()),(now())... only eval once, treated as constant.
There was a problem hiding this comment.
The comment format is like expr(variable name) ....
AilinKid
force-pushed
the
lazy_default_seq_expr
branch
from
995a092
to
7dc9eb6
Compare
zimulala
reviewed
Mar 10, 2020
ddl/sequence_test.go
Outdated
| for i := 0; i < 100; i++ { | ||
| s.tk.MustExec(sql) | ||
| } | ||
| // fmt.Println(time.Now().Sub(start) / 100) |
There was a problem hiding this comment.
surely, this just show how we bench it.
ghost
removed their request for review
|
/build |
AilinKid
added
status/LGT2
|
/run-all-tests |
djshow832
previously approved these changes
Mar 18, 2020
|
/merge |
sre-bot
added
the
status/can-merge
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/merge |
|
/run-all-tests |
djshow832
approved these changes
Mar 19, 2020
|
/merge |
|
/run-all-tests |
|
@AilinKid merge failed. |
|
/merge |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
support default expression cache when insert.
It will accelerate the eval speed of the column with a default expression.
simple bench:
before
now
What is changed and how it works?
Check List
Tests
Release note