Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

executor: insert negative primary key into auto_random table won't trigger rebase (#15397) #17987

Merged
merged 3 commits into from
Jul 6, 2020
Merged

executor: insert negative primary key into auto_random table won't trigger rebase (#15397) #17987

merged 3 commits into from
Jul 6, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jun 12, 2020 •
edited
Loading

Cherry-pick #15397.

Release note

  • Insert negative primary key into auto_random table won't trigger rebase.

@github-actions github-actions bot added the sig/execution SIG execution label Jun 12, 2020
@tangenta tangenta requested review from AilinKid and bb7133 July 2, 2020 03:44
AilinKid
AilinKid reviewed Jul 3, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

executor/insert_common.go Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@AilinKid, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

1 similar comment
@ti-srebot
Copy link
Contributor

@AilinKid, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

AilinKid
AilinKid reviewed Jul 6, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

executor/insert_common.go Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@AilinKid, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

1 similar comment
@ti-srebot
Copy link
Contributor

@AilinKid, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

bb7133
bb7133 approved these changes Jul 6, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@bb7133, Thanks for your review, however we are sorry that your vote won't be count. You are not a reviewer or committer or co-leader or leader for the related sigs:execution(slack).

@bb7133 bb7133 added this to the v4.0.3 milestone Jul 6, 2020
@bb7133
Copy link
Member

bb7133 commented Jul 6, 2020

/run-all-tests

@bb7133
Copy link
Member

bb7133 commented Jul 6, 2020

/run-unit-test

@tangenta
Copy link
Contributor Author

tangenta commented Jul 6, 2020

/run-unit-test

FAIL: sort_test.go:26: testSuite.TestSortInDisk

sort_test.go:60:
    c.Assert(tk.Se.GetSessionVars().StmtCtx.DiskTracker.MaxConsumed(), Greater, int64(0))
... compare_one int64 = 0
... compare_two int64 = 0

@bb7133 bb7133 merged commit cd6623b into pingcap:release-4.0 Jul 6, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution type/4.0-cherry-pick
Projects
None yet
Milestone
v4.0.3
Development

Successfully merging this pull request may close these issues.
4 participants
@tangenta @ti-srebot @bb7133 @AilinKid