Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sessionctx, executor: add session var to control explicit insertion on auto_random column (#17102) #18508

Merged
merged 2 commits into from
Jul 13, 2020
Merged

sessionctx, executor: add session var to control explicit insertion on auto_random column (#17102) #18508

merged 2 commits into from
Jul 13, 2020

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 13, 2020 •
edited
Loading

Cherry-pick #17102 to release-4.0.

Release note

  • A new session variable named tidb_allow_auto_random_explicit_insert is added, which controls whether explicit insertion on auto_random column is allowed.

crazycs520
crazycs520 reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

AilinKid
AilinKid approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 13, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 13, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

@github-actions github-actions bot added sig/sql-infra SIG: SQL Infra sig/execution SIG execution labels Jul 13, 2020
@tangenta
Copy link
Contributor Author

/run-all-tests

@tangenta
Copy link
Contributor Author

/run-unit-test

 db_test.go:1006:
     testAddIndex(c, s.store, s.lease, false,
         "create table test_add_index (c1 bigint, c2 bigint, c3 bigint, primary key(c1))", "")
 /home/jenkins/agent/workspace/tidb_ghpr_unit_test/go/src/github.com/pingcap/tidb/util/testkit/testkit.go:190:
     tk.c.Assert(err, check.IsNil, check.Commentf("sql:%s, %v, error stack %v", sql, args, errors.ErrorStack(err)))
 ... value *errors.withStack = [domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV ("[domain:8027]Information schema is out of date: schema failed to update in 1 lease, please make sure TiDB can connect to TiKV")

@bb7133 bb7133 merged commit 89e34b7 into pingcap:release-4.0 Jul 13, 2020
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazycs520 crazycs520 crazycs520 left review comments

@AilinKid AilinKid AilinKid approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tangenta @AilinKid @crazycs520 @ti-srebot @bb7133