Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executor: INLHJ worker return err to main thread (#18573) #18586

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #18573 to release-4.0


What problem does this PR solve?

Issue Number: close #18572

Problem Summary:
Before this commit, the error happened during the outer/inner worker of indexHashJoin is not returned to the main thread.

What is changed and how it works?

What's Changed:
As the title says.

How it Works:

Related changes

  • Need to cherry-pick to the release branch
    v4.0.0

Check List

Tests

  • Integration test

Side effects

N/A

Release note

  • Return an error instead of an empty set for IndexHashJoin when an error happens during execution.

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@SunRunAway SunRunAway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 15, 2020
Copy link
Contributor

@lzmhhh123 lzmhhh123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 15, 2020
@XuHuaiyu
Copy link
Contributor

/run-unit-test

@XuHuaiyu XuHuaiyu changed the title executor: return error from indexHashJoin worker to main thread (#18573) executor: INLHJ worker return err to main thread (#18573) Jul 15, 2020
@XuHuaiyu XuHuaiyu merged commit 9e25dc4 into pingcap:release-4.0 Jul 15, 2020
@XuHuaiyu XuHuaiyu deleted the release-4.0-c2b56e96c8db branch July 15, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug. type/4.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants