Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: remove allow-auto-random config option (#16596) #18613

Merged
merged 3 commits into from
Jul 16, 2020
Merged

config: remove allow-auto-random config option (#16596) #18613

merged 3 commits into from
Jul 16, 2020

Conversation

tangenta
Copy link
Contributor

Cherry-pick #17423, #16596 to release-4.0.

Release note

  • The column attribute auto_random gets stable and it can be used without the config option allow-auto-random.

@tangenta tangenta force-pushed the release-4.0-autorand-rm-config branch from 22073fa to 2bc02be Compare July 16, 2020 02:14
@tangenta
Copy link
Contributor Author

/run-all-tests

@tangenta
Copy link
Contributor Author

/run-all-tests

AilinKid
AilinKid reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@tangenta
Copy link
Contributor Author

/run-integration-copr-test

1 similar comment
@AilinKid
Copy link
Contributor

/run-integration-copr-test

bb7133
bb7133 approved these changes Jul 16, 2020
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Jul 16, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 16, 2020
@bb7133 bb7133 merged commit b10faca into pingcap:release-4.0 Jul 16, 2020
@3pointer 3pointer mentioned this pull request Jul 16, 2020
Merged
@bb7133 bb7133 mentioned this pull request Jul 23, 2020
Merged
5 tasks
@amyangfei amyangfei mentioned this pull request Jul 29, 2020
Merged
@tangenta tangenta mentioned this pull request Oct 9, 2020
Merged
9 tasks
@ti-srebot ti-srebot mentioned this pull request Oct 10, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AilinKid AilinKid AilinKid left review comments

@bb7133 bb7133 bb7133 approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

Assignees
No one assigned
Labels
component/config sig/execution SIG execution sig/sql-infra SIG: SQL Infra status/LGT2 Indicates that a PR has LGTM 2. type/4.0-cherry-pick
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangenta @AilinKid @bb7133 @ti-srebot