*: fix auto-id allocate tracing #22371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiancaiamao
added
the
type/enhancement
github-actions
bot
added
sig/execution
|
/rebuild |
ti-srebot
approved these changes
Jan 13, 2021
|
/merge |
ti-srebot
added
the
status/can-merge
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
I'm misled by the trace result of auto-id allocating.
The code is not placed in the correct place.
The allocator caches
baseandendof the IDs, so even the code run toAlloc(), that does not necessarily mean obtaining a new auto-id from TiKV.What is changed and how it works?
What's Changed:
func RunInNewTxn(ctx context.Context ...)function.opentracing.SpanFromContextcode fromAlloc()toRunInNewTxnHow it Works:
Move the tracing code to the correct place.
Check List
Tests
Release note