Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session: fix bug user privileges change after upgrade from 4.0.11 to 5.0 #23403

Merged
merged 8 commits into from
Mar 25, 2021
Merged

session: fix bug user privileges change after upgrade from 4.0.11 to 5.0 #23403

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c367254
session: fix bug user privileges change after upgrade from 4.0.11 to 5.0
tiancaiamao Mar 18, 2021
34d842d
address comment
tiancaiamao Mar 22, 2021
cbe74de
make golint happy
tiancaiamao Mar 22, 2021
e59eb30
make golint happy
tiancaiamao Mar 22, 2021
78795f5
Merge branch 'master' into issue-23387
tiancaiamao Mar 22, 2021
e8f3544
address comment
tiancaiamao Mar 24, 2021
ed96ff8
fix a testleak fail in CI
tiancaiamao Mar 25, 2021
08363bf
Merge branch 'master' into issue-23387
ti-chi-bot Mar 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion session/bootstrap.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,7 +1443,7 @@ func upgradeToVer64(s Session, ver int64) {
}
doReentrantDDL(s, "ALTER TABLE mysql.user ADD COLUMN `Repl_slave_priv` ENUM('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' AFTER `Execute_priv`", infoschema.ErrColumnExists)
doReentrantDDL(s, "ALTER TABLE mysql.user ADD COLUMN `Repl_client_priv` ENUM('N','Y') CHARACTER SET utf8 NOT NULL DEFAULT 'N' AFTER `Repl_slave_priv`", infoschema.ErrColumnExists)
mustExecute(s, "UPDATE HIGH_PRIORITY mysql.user SET Repl_slave_priv='Y',Repl_client_priv='Y'")
mustExecute(s, "UPDATE HIGH_PRIORITY mysql.user SET Repl_slave_priv='Y',Repl_client_priv='Y' where Super_priv='Y'")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do any operations rely on these privileges? I'm afraid it will break compatibility if you shrink the privilege.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the description has clarified the case:

it adds Repl_slave_priv to all existing users while it should just do that for the root user.

}

func upgradeToVer65(s Session, ver int64) {
Expand Down