Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix "order by + num " can use a column not in select fields #24669

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

time-and-fate
Copy link
Member

What problem does this PR solve?

Issue Number: close #24667

What is changed and how it works?

What's Changed:

How it Works:

Related changes

  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test

Release note

  • no release note.

@time-and-fate time-and-fate requested a review from a team as a code owner May 14, 2021 10:03
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@time-and-fate time-and-fate requested review from rebelice and removed request for a team May 14, 2021 10:03
@ti-chi-bot ti-chi-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 14, 2021
@ichn-hu ichn-hu mentioned this pull request May 14, 2021
@ti-chi-bot
Copy link
Member

@time-and-fate: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2021
@rebelice rebelice removed their request for review October 9, 2022 02:51
@ti-chi-bot ti-chi-bot bot deleted a comment from ti-chi-bot Dec 19, 2023
Copy link

tiprow bot commented Feb 27, 2024

@time-and-fate: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
tiprow_fast_test d8744a5 link true /test fast_test_tiprow

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

ti-chi-bot bot commented Apr 10, 2024

@time-and-fate: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/check_dev_2 d8744a5 link true /test check-dev2
pull-integration-ddl-test d8744a5 link true /test pull-integration-ddl-test
idc-jenkins-ci-tidb/check_dev d8744a5 link true /test check-dev
pull-mysql-client-test d8744a5 link true /test pull-mysql-client-test
idc-jenkins-ci-tidb/unit-test d8744a5 link true /test unit-test
idc-jenkins-ci-tidb/build d8744a5 link true /test build
idc-jenkins-ci-tidb/mysql-test d8744a5 link true /test mysql-test
pull-br-integration-test d8744a5 link true /test pull-br-integration-test
pull-lightning-integration-test d8744a5 link true /test pull-lightning-integration-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"order by + num " can use a column not in select fields
2 participants