Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expression: Support Sqrt, Ceil, Floor and CastIntAsReal push down to TiFlash #25085

Merged
merged 21 commits into from
Jun 4, 2021
Merged

expression: Support Sqrt, Ceil, Floor and CastIntAsReal push down to TiFlash #25085

merged 21 commits into from
Jun 4, 2021

Conversation

chAngeZhaoZhanBo
Copy link
Contributor

@chAngeZhaoZhanBo chAngeZhaoZhanBo commented Jun 3, 2021 •
edited
Loading

What problem does this PR solve?

Related to pingcap/tiflash#1901
Issue Number: close #xxx

Problem Summary:

What is changed and how it works?

What's Changed:
Add Floor, Ceil, Sqrt and CastIntAsReal(for pushing down a sqrt for an int) into scalarExprSupportedByFlash list

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Use tiflash/integrated/ops or algernon to run a tidb-server and use explain query to make sure corresponding expression is pushed down

Side effects

Release note

  • Pushdown sqrt, ceil, floor and CastIntAsReal to tiflash

@chAngeZhaoZhanBo chAngeZhaoZhanBo requested a review from a team as a code owner June 3, 2021 06:19
@chAngeZhaoZhanBo chAngeZhaoZhanBo requested review from qw4990 and removed request for a team June 3, 2021 06:19
@CLAassistant
Copy link

CLAassistant commented Jun 3, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

jackysp
jackysp approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 3, 2021
@chAngeZhaoZhanBo
Copy link
Contributor Author

/cc @qw4990

@ti-chi-bot ti-chi-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 4, 2021
@ti-chi-bot ti-chi-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 4, 2021
@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@LittleFall
Copy link
Contributor

/run-check_release_note

@ti-srebot
Copy link
Contributor

No release note, Please follow https://github.com/pingcap/community/blob/master/contributors/release-note-checker.md

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-check_dev_2

@zanmato1984
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 2cfa992

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 4, 2021
@zanmato1984
Copy link
Contributor

/run-all-tests

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-check_dev_2

@zanmato1984
Copy link
Contributor

/merge

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-all-tests

@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-all-tests

1 similar comment
@chAngeZhaoZhanBo
Copy link
Contributor Author

/run-all-tests

@LittleFall
Copy link
Contributor

/merge

1 similar comment
@LittleFall
Copy link
Contributor

/merge

@LittleFall
Copy link
Contributor

/merge

chabuduodel

@LittleFall
Copy link
Contributor

/merge

@zanmato1984
Copy link
Contributor

/chabuduodel

@ti-chi-bot ti-chi-bot merged commit 5e55c2e into pingcap:master Jun 4, 2021
@ti-srebot ti-srebot mentioned this pull request Jun 4, 2021
Closed
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #25178

@LittleFall
Copy link
Contributor

/chabuduodel

so effectively

chAngeZhaoZhanBo added a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
@chAngeZhaoZhanBo
expression: Support Sqrt, Ceil, Floor and CastIntAsReal push down to …
34ba6b3 
…TiFlash (pingcap#25085)
chAngeZhaoZhanBo added a commit to ti-srebot/tidb that referenced this pull request Jun 17, 2021
@chAngeZhaoZhanBo
expression: Support Sqrt, Ceil, Floor and CastIntAsReal push down to …
bdcbfa5 
…TiFlash (pingcap#25085)
@chAngeZhaoZhanBo chAngeZhaoZhanBo mentioned this pull request Jun 21, 2021
Merged
This was referenced Aug 5, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanmato1984 zanmato1984 zanmato1984 approved these changes

@jackysp jackysp jackysp approved these changes

@LittleFall LittleFall LittleFall approved these changes

@qw4990 qw4990 Awaiting requested review from qw4990

Assignees
No one assigned
Labels
component/expression needs-cherry-pick-release-5.0 size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@chAngeZhaoZhanBo @CLAassistant @ti-srebot @LittleFall @ti-chi-bot @zanmato1984 @jackysp