Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expression: push down left/right/char_length (#24840) #25563

Closed

Conversation

ti-srebot
Copy link
Contributor

@ti-srebot ti-srebot commented Jun 18, 2021

cherry-pick #24840 to release-5.0
You can switch your code base to this Pull Request by using git-extras:

# In tidb repo:
git pr https://github.com/pingcap/tidb/pull/25563

After apply modifications, you can push your change to this PR via:

git push git@github.com:ti-srebot/tidb.git pr/25563:release-5.0-087f392d22d7

What problem does this PR solve?

Issue Number: close pingcap/tiflash#1943

Problem Summary: push down left/right without cosidering collation, char_length aims to verification.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Integration test
  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression
    • Consumes more CPU
    • Consumes more MEM
  • Breaking backward compatibility

Release note

  • push down left/right/char_length to tiflash

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot requested a review from a team as a code owner June 18, 2021 07:27
@ti-srebot ti-srebot requested review from lzmhhh123 and removed request for a team June 18, 2021 07:27
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot added component/expression size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick labels Jun 18, 2021
@ti-srebot ti-srebot added this to the v5.0.2 milestone Jun 18, 2021
@ti-srebot
Copy link
Contributor Author

@fzhedu you're already a collaborator in bot's repo.

@qw4990 qw4990 removed their request for review June 23, 2021 03:34
@lzmhhh123 lzmhhh123 removed their request for review July 5, 2021 02:09
@zhouqiang-cl zhouqiang-cl added the cherry-pick-approved Cherry pick PR approved by release team. label Aug 30, 2021
@XuHuaiyu
Copy link
Contributor

New feature, do not need to cherrypick

@XuHuaiyu XuHuaiyu closed this Dec 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-approved Cherry pick PR approved by release team. component/expression size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/5.0-cherry-pick
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants