Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: Split TestTLS #27108

Merged
merged 3 commits into from
Aug 13, 2021
Merged

server: Split TestTLS #27108

merged 3 commits into from
Aug 13, 2021

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 11, 2021

What problem does this PR solve?

Issue Number: #26947

Problem Summary: TestTLS can take more than 3 minutes. Splitting this helps to identify what part is problematic

Release note

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Aug 11, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tiancaiamao

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 11, 2021
@github-actions github-actions bot added the sig/sql-infra SIG: SQL Infra label Aug 11, 2021
@dveeden
Copy link
Contributor Author

dveeden commented Aug 11, 2021

/run-check_dev_2

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-check_dev_2

@dveeden
Copy link
Contributor Author

dveeden commented Aug 12, 2021

/cc @tiancaiamao @morgo

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 13, 2021
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 13, 2021
@morgo
Copy link
Contributor

morgo commented Aug 13, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: effb301

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Aug 13, 2021
@ti-chi-bot ti-chi-bot merged commit 124b825 into pingcap:master Aug 13, 2021
@zhouqiang-cl
Copy link
Contributor

Seems TestTLSAuto still take much time
[2021-08-17T02:30:32.622Z] PASS: tidb_test.go:874: tidbTestSerialSuite.TestTLSAuto 6.148s

in ci https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/26519/pipeline

@dveeden
Copy link
Contributor Author

dveeden commented Aug 18, 2021

Seems TestTLSAuto still take much time
[2021-08-17T02:30:32.622Z] PASS: tidb_test.go:874: tidbTestSerialSuite.TestTLSAuto 6.148s

in ci https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/26519/pipeline

@zhouqiang-cl Yes, that's why #26947 is not closed yet. This is due to the RSA key size and the issue has a proposed solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. sig/sql-infra SIG: SQL Infra size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants