-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tables: fix insert ignore on duplicate with dup prefix 2nd index (#25905) #27510
Conversation
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
[REVIEW NOTIFICATION] This pull request has not been approved. To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/run-all-tests |
@ti-srebot: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lysu you're already a collaborator in bot's repo. |
3.0 have no clustered index, there are no those problem |
cherry-pick #25905 to release-3.0
You can switch your code base to this Pull Request by using git-extras:
# In tidb repo: git pr https://github.com/pingcap/tidb/pull/27510
After apply modifications, you can push your change to this PR via:
What problem does this PR solve?
Issue Number: close #25809
Problem Summary:
now it relies on
modified
array to decide whether skip modified index dup check after duplicate updated.but when clustered primary key has same column with secondary index,and the column is prefix, changed in table doesn't indicate it be change in index.
What is changed and how it works?
What's Changed, How it Works:
truncate datum to index length and re-check modified for prefix column
Related changes
Check List
Tests
Side effects
Release note