store/copr: migrate test-infra to testify #27716
Conversation
Signed-off-by: Ranxy <huran@outlook.com>
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
ti-chi-bot
added
release-note-none
| type main struct { | ||
| m *testing.M | ||
| } | ||
|
|
||
| func (m *main) Run() int { | ||
| c := m.m.Run() | ||
| // In order for MVCCLevelDB to close, we need to wait one second | ||
| time.Sleep(time.Second) | ||
| return c | ||
| } |
There was a problem hiding this comment.
BTW, this is a nice pattern I'd like to learn. Thanks!
There was a problem hiding this comment.
You may be interested in 9303e33#diff-c82f35d024189fbb1b0627d10999e1c601d107cb051e23ceccf89002da395af5
|
@tisonkun: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
ti-chi-bot
added
status/LGT2
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 1359e53
|
ti-chi-bot
added
the
status/can-merge
|
@Ranxy: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
Signed-off-by: Ranxy huran@outlook.com
What problem does this PR solve?
Issue Number: close #27654
What is changed and how it works?
Migrate test-infra to testify for store/copr pkg.
Release note