Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lightning: Fix empty region pre-check #27824

Merged
merged 10 commits into from
Sep 7, 2021
Merged

lightning: Fix empty region pre-check #27824

merged 10 commits into from
Sep 7, 2021

Conversation

Little-Wallace
Copy link
Contributor

@Little-Wallace Little-Wallace commented Sep 6, 2021 •
edited
Loading

Signed-off-by: Little-Wallace bupt2013211450@gmail.com

What problem does this PR solve?

Problem Summary:
Lightning can not pass pre-check when user try to import a large of number tables but he does not disable split-on-table of TiDB configure.

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note 

None

@Little-Wallace
remote offline
46d24f4 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 6, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • glorv
  • gozssky

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 6, 2021
@Little-Wallace Little-Wallace added the component/lightning This issue is related to Lightning of TiDB. label Sep 6, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 6, 2021
sleepymole
sleepymole reviewed Sep 6, 2021
View reviewed changes
Copy link
Contributor

@sleepymole sleepymole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

br/pkg/lightning/restore/check_info.go Outdated
@@ -263,7 +315,7 @@ func (rc *Controller) checkRegionDistribution(ctx context.Context) error {
}

// CheckClusterRegion checks cluster if there are too many empty regions or region distribution is unbalanced.
func (rc *Controller) CheckClusterRegion(ctx context.Context) error {
func (rc *Controller) CheckClusterRegion(ctx context.Context, controller *pdutil.PdController) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems the new controller argument is not used

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.... It is a bad code...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

br/pkg/lightning/restore/check_info.go Outdated
@@ -19,6 +19,7 @@ import (
"context"
"fmt"
"io"
"modernc.org/mathutil"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need move to next import group

@Little-Wallace
address comment
3b3cc05 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 6, 2021
@Little-Wallace
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 1c98275

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@ti-chi-bot ti-chi-bot removed the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@Little-Wallace
fix test
235b24c 
Signed-off-by: Little-Wallace <bupt2013211450@gmail.com>
@kennytm
Copy link
Contributor

kennytm commented Sep 6, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 235b24c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 6, 2021
@Little-Wallace
Copy link
Contributor Author

/run-check_dev_2

@Little-Wallace
Copy link
Contributor Author

/run-check_dev_2

3 similar comments
@Little-Wallace
Copy link
Contributor Author

/run-check_dev_2

@Little-Wallace
Copy link
Contributor Author

/run-check_dev_2

@Little-Wallace
Copy link
Contributor Author

/run-check_dev_2

@kennytm
Copy link
Contributor

kennytm commented Sep 6, 2021

/run-check_dev_2

https://ci.pingcap.net/blue/organizations/jenkins/tidb_ghpr_check_2/detail/tidb_ghpr_check_2/31616/pipeline

#15594

@ti-chi-bot ti-chi-bot merged commit 254eaea into pingcap:master Sep 7, 2021
joccau pushed a commit to joccau/tidb that referenced this pull request Sep 7, 2021
@Little-Wallace
lightning: Fix empty region pre-check (pingcap#27824)
dcabd5e
@glorv glorv mentioned this pull request Jan 14, 2022
Closed
@niubell
Copy link
Contributor

niubell commented Apr 12, 2022

/label needs-cherry-pick-5.2

ti-srebot pushed a commit to ti-srebot/tidb that referenced this pull request Apr 12, 2022
@Little-Wallace @ti-srebot
cherry pick pingcap#27824 to release-5.2
4dd273e 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Apr 12, 2022
Closed
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.2 in PR #33885

@glorv
Copy link
Contributor

glorv commented Apr 12, 2022

@niubell Why cherry-pick this PR into v5.2?

@niubell
Copy link
Contributor

niubell commented Apr 13, 2022

The issue #27749 has affects-5.2 label, shouldn't we?

@niubell
Copy link
Contributor

niubell commented Apr 13, 2022

/remove-label needs-cherry-pick-5.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glorv glorv glorv approved these changes

@sleepymole sleepymole sleepymole approved these changes

Assignees
No one assigned
Labels
component/lightning This issue is related to Lightning of TiDB. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Little-Wallace @ti-chi-bot @kennytm @niubell @ti-srebot @glorv @sleepymole