-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
statistics: skip build statistics for view in auto analyze #27866
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
@tiancaiamao does this pr need to cherry-pick? |
/merge |
This pull request has been accepted and is ready to merge. Commit hash: 8cc46ae
|
/merge |
/run-check_dev_2 |
@tiancaiamao: Your PR was out of date, I have automatically updated it for you. At the same time I will also trigger all tests for you: /run-all-tests If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
What problem does this PR solve?
Issue Number: close #27274
I'm not sure will it also close #25898 and #26539, because in those two, the data race stack is lost.
After this fix, if we don't see them in the future, that means they are also fixed.
Problem Summary:
The DATA RACE happen between
explain view
(or "select * from information_schema.columns") and auto-analyze.Auto analyze need to read the table column info, while 'explain view' will modify it.
tryFillViewColumnType
will modify the column in model.TableInfo, It's not a operation on a copy of data.This operation is dangerous.
What is changed and how it works?
What's Changed:
View is a special table, it doesn't not need to maintain the statistics.
This commit skip build statistics for view.
How it Works:
Statistics will skip the view table, so it doesn't conflict with the
explain view
orselect * from infoschema.columns
...Maybe change the
tryFillViewColumnType
function is another option, but this fix is obviously right, and just one line change.Check List
Tests
Side effects
Documentation
Release note