Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bindinfo: migrate test-infra to testify(staging-2) #28070

Merged
merged 7 commits into from
Sep 22, 2021
Merged

bindinfo: migrate test-infra to testify(staging-2) #28070

merged 7 commits into from
Sep 22, 2021

Conversation

w169q169
Copy link
Contributor

@w169q169 w169q169 commented Sep 15, 2021 •
edited
Loading

What problem does this PR solve?

Issue Number: ref #27177

Release note 

None

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Sep 15, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • morgo
  • tisonkun

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 15, 2021
@w169q169
Copy link
Contributor Author

/cc @tisonkun

@tisonkun
Copy link
Contributor

@w169q169 I guess this one cannot "close" the issue, so you can use "to" or "ref" which has no magic but a reference.

tisonkun
tisonkun reviewed Sep 16, 2021
View reviewed changes
bindinfo/session_handle_test.go Outdated
"github.com/stretchr/testify/require"
)

func TestGlobalAndSessionBindingBothExist(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If these tests are run in serial, please name the file "xxx_serial_test.go"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w169q169 "these tests" mean all of the tests in this file, not only the commented one.

The rationale is that we'd prefer to run test in parallel for efficiency, and in order to help contributors be aware of whether a bunch of tests run in parallel or not, make serial test secondary and move then all in "xxx_serial_test.go"

Copy link
Contributor Author

@w169q169 w169q169 Sep 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tisonkun I got it. I make it wrong in the previous commit and I have fixed it.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2021
@w169q169
Copy link
Contributor Author

/cc @morgo
PTAL

morgo
morgo requested changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM

bindinfo/session_handle_serial_test.go Outdated Show resolved Hide resolved
bindinfo/session_handle_serial_test.go Outdated Show resolved Hide resolved
bindinfo/session_handle_serial_test.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Sep 20, 2021
@w169q169 w169q169 requested a review from morgo September 22, 2021 01:11
morgo
morgo approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@morgo morgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 22, 2021
tisonkun
tisonkun approved these changes Sep 22, 2021
View reviewed changes
Copy link
Contributor

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your review @morgo ! Reapply my approval.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Sep 22, 2021
@morgo
Copy link
Contributor

morgo commented Sep 22, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 7c1628c

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 22, 2021
@ti-chi-bot
Copy link
Member

@w169q169: Your PR was out of date, I have automatically updated it for you.

At the same time I will also trigger all tests for you:

/run-all-tests

If the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot merged commit ce3370f into pingcap:master Sep 22, 2021
@w169q169 w169q169 deleted the issue-27177-staging-2 branch September 22, 2021 03:00
@w169q169 w169q169 mentioned this pull request Sep 22, 2021
Closed
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@morgo morgo morgo approved these changes

@tisonkun tisonkun tisonkun approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@w169q169 @ti-chi-bot @tisonkun @morgo